New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There seems to be no way to add custom labels to the ClusterRole and ClusterRoleBinding #573

Open

mnp opened this issue Nov 22, 2024 · 0 comments

mnp commented Nov 22, 2024

The daemonset, etc have this, which makes sense:

  labels:
    {{- include "fluent-bit.labels" . | nindent 4 }}
    {{- with .Values.labels }}
      {{- toYaml . | nindent 4 }}
    {{- end }}

but the pattern is not the same for ClusterRole and ClusterRoleBinding:

  labels:
    {{- include "fluent-bit.labels" . | nindent 4 }}

So I think they need to have .Values.labels to follow the pattern, or else add a new top level key like .Values.clusterRole.labels.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment