Add throttling metrics #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Athish Pranav D <[email protected]>
Signed-off-by: Athish Pranav D <[email protected]>
|
@ashie this is dependent on fluent/fluentd#4578 Like the above PR is merged, but whoever didn't update Fluentd will have error if they use this code (since the metrics reference is dangling). What's your suggestion for it? |
Please check existence of |
Signed-off-by: Athish Pranav D <[email protected]>
|
@ashie I will add the manual testing info once i get time |
|
|
|
@ashie any other checks do you want me to do? |
ashie
approved these changes
Aug 9, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues this PR solves
#190
Why is this PR needed?
Add observability on throttling in
in_tailpluginfluent/fluentd#4578 - corresponding metrics PR in
in_tail