Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLP*: Doesn't respect input IDs #292

Open
weefuzzy opened this issue Dec 24, 2024 · 0 comments
Open

MLP*: Doesn't respect input IDs #292

weefuzzy opened this issue Dec 24, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@weefuzzy
Copy link
Member

The MLP client training code seems to assume that the input and output data / labels are identically ordered, and never checks that this is the case. Much of the time it is, but one can simply 'reorder' the entries of a Dataset – which should remain semantically equivalent because it's an unordered collection – and completely screw up one's training.

There's no particularly nice solution to this: we just have to traverse the ID list of one of the data sets and rearrange (a copy of) the other to match. Current fix in progress introduces a new flag (strict) to enable this, because it's not cheap.

@weefuzzy weefuzzy added the bug Something isn't working label Dec 24, 2024
@weefuzzy weefuzzy self-assigned this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant