Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iframe embed option fields #119

Open
bbbo opened this issue Oct 24, 2016 · 5 comments
Open

add iframe embed option fields #119

bbbo opened this issue Oct 24, 2016 · 5 comments
Assignees

Comments

@bbbo
Copy link
Member

bbbo commented Oct 24, 2016

on the configuration page, so users can set an iframe source (and optionally height and width),
see https://flowplayer.org/docs/embedding.html#iframe-embedding . The contents will go into the embed: config object, like

embed: {
// embed including quality selector
iframe: "//flowplayer.org/standalone/multires/drive-iframe.html",
width: "864px",
height: "364px" // 360 + 4 ! player height + room for slim timeline
}

If an iframe is set, also add the fullscreen options to the global configuration? ) @blacktrash any negative side effects?

/*
additional global configuration to handle fullscreen behaviour of embedded
iframes
*/
flowplayer.conf = {

// allow iframe go fullscreen
fullscreen: true,

// fullscreen from iframe on tablets
native_fullscreen: true

};

@phloxic
Copy link

phloxic commented Oct 24, 2016

Should not be needed with upcoming flowplayer 7; embed will always be iframe, and iframe will be responsive if neither height or width are given.
That includes a better handling of the slim timeline thing as well, because that does not apply to fixed-controls and no-toggle modifier classes (nevermind what will change in the design, may still have to be adapted).

@phloxic
Copy link

phloxic commented Oct 24, 2016

Also, at least in the current state, the config stuff is meant of the iframe source, which is usually not the player one sees on site?

@bbbo
Copy link
Member Author

bbbo commented Oct 24, 2016

the embed option quoted above are for the player setup?

@phloxic
Copy link

phloxic commented Oct 24, 2016

native_fullscreen and fullscreen are normally only required for the iframe source.

@bbbo
Copy link
Member Author

bbbo commented Mar 21, 2018

I think this is still needed as the standard embed iframe does not transport ad configurations for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants