-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add iframe embed option fields #119
Comments
Should not be needed with upcoming flowplayer 7; embed will always be iframe, and iframe will be responsive if neither height or width are given. |
Also, at least in the current state, the config stuff is meant of the iframe source, which is usually not the player one sees on site? |
the embed option quoted above are for the player setup? |
|
I think this is still needed as the standard embed iframe does not transport ad configurations for example |
on the configuration page, so users can set an iframe source (and optionally height and width),
see https://flowplayer.org/docs/embedding.html#iframe-embedding . The contents will go into the embed: config object, like
embed: {
// embed including quality selector
iframe: "//flowplayer.org/standalone/multires/drive-iframe.html",
width: "864px",
height: "364px" // 360 + 4 ! player height + room for slim timeline
}
If an iframe is set, also add the fullscreen options to the global configuration? ) @blacktrash any negative side effects?
/*
additional global configuration to handle fullscreen behaviour of embedded
iframes
*/
flowplayer.conf = {
};
The text was updated successfully, but these errors were encountered: