moved the history level check into out of the HistoricVariableInstanc… #3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eEntityManangerImpl and into the classes that called the methods.
dbmalkovsky
reviewed
Jan 18, 2024
| @@ -38,7 +39,9 @@ public Object execute(CommandContext commandContext) { | |||
| } | |||
| } | |||
| processEngineConfiguration.getTaskServiceConfiguration().getHistoricTaskService().deleteHistoricTaskLogEntriesForNonExistingProcessInstances(); | |||
| processEngineConfiguration.getVariableServiceConfiguration().getHistoricVariableService().deleteHistoricVariableInstancesForNonExistingProcessInstances(); | |||
| if(processEngineConfiguration.getHistoryManager().isHistoryLevelAtLeast(HistoryLevel.ACTIVITY)){ | |||
There was a problem hiding this comment.
Suggested change
| if(processEngineConfiguration.getHistoryManager().isHistoryLevelAtLeast(HistoryLevel.ACTIVITY)){ | |
| if (processEngineConfiguration.getHistoryManager().isHistoryLevelAtLeast(HistoryLevel.ACTIVITY)){ |
added a space
dbmalkovsky
reviewed
Jan 18, 2024
| @@ -146,12 +143,10 @@ public List<HistoricVariableInstanceEntity> findHistoricalVariableInstancesBySub | |||
|
|
|||
| @Override | |||
| public void deleteHistoricVariableInstancesByTaskId(String taskId) { | |||
| if (serviceConfiguration.isHistoryLevelAtLeast(HistoryLevel.ACTIVITY)) { | |||
There was a problem hiding this comment.
Given that the if is removed shouldn't the indentation of the following lines be changed too?
WelschChristopher
force-pushed
the
move-history-check-for-variable-deletion
branch
from
49d275f
to
c2b094e
Compare
WelschChristopher
force-pushed
the
move-history-check-for-variable-deletion
branch
from
5e069d2
to
ef62328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eEntityManangerImpl and into the classes that called the methods.
Check List: