adding option to have an inbound event filter in the default event inbound pipeline #3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roumn
reviewed
Jan 11, 2024
|
|
||
| // if there is a custom filter in place, invoke it to filter the event for further processing or to abort the pipeline | ||
| if (inboundEventFilter != null) { | ||
| if (!inboundEventFilter.filter(event)) { |
There was a problem hiding this comment.
Can we add a debug logging statement here?
jbarrez
added a commit
that referenced
this pull request
Jan 15, 2024
- Move filtering into separate step of the pipeline - Change method name to 'retain' to make purpose clearer - Add logging
|
Merged manually: 895a8e4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new option to have an event filter delegate expression within the default inbound event pipeline.
Check List: