Support manual event subscription based case event-registry start #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbmalkovsky
reviewed
Jan 8, 2024
| CaseInstanceStartEventSubscriptionModificationBuilder createCaseInstanceStartEventSubscriptionModificationBuilder(); | ||
|
|
||
| /** | ||
| * Creates a new event subscription deletion builder delete one or more previously registered case start event subscriptions based |
There was a problem hiding this comment.
Suggested change
| * Creates a new event subscription deletion builder delete one or more previously registered case start event subscriptions based | |
| * Creates a new event subscription deletion builder to delete one or more previously registered case start event subscriptions based |
dbmalkovsky
reviewed
Jan 8, 2024
|
|
||
| } else { | ||
| throw new FlowableObjectNotFoundException("Case definition with key '" + caseDefinitionKey + | ||
| "' and tenantId '"+ tenantId +"' was not found", CaseDefinition.class); |
There was a problem hiding this comment.
Suggested change
| "' and tenantId '"+ tenantId +"' was not found", CaseDefinition.class); | |
| "' and tenantId '"+ tenantId +"' was not found.", CaseDefinition.class); |
For consistency with other messages
dbmalkovsky
reviewed
Jan 8, 2024
| import org.flowable.common.engine.impl.interceptor.CommandContext; | ||
|
|
||
| /** | ||
| * This command either modifies event subscriptions with a case start event and optional correlation parameter values. |
There was a problem hiding this comment.
Suggested change
| * This command either modifies event subscriptions with a case start event and optional correlation parameter values. | |
| * This command either deletes event subscriptions with a case start event and optional correlation parameter values. |
added 2 commits
January 9, 2024 08:25
…t a new case based on a specific combination of correlation values
mkiener
force-pushed
the
dynamic-event-registry-case-start
branch
from
7d40dae
to
b68e0f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for dynamic, manually created event subscriptions with any combination of correlation parameter values for an event-registry based case start.
Check List:
Unit tests: YES
Documentation: NO