Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child process is not killed on SIGTERM #88

Open
mkscrg opened this issue Oct 21, 2017 · 0 comments
Open

Child process is not killed on SIGTERM #88

mkscrg opened this issue Oct 21, 2017 · 0 comments

Comments

@mkscrg
Copy link

mkscrg commented Oct 21, 2017 •
edited
Loading

cli.js does not kill the child process before exiting on SIGTERM.

Repro:

$ ./node_modules/.bin/flow server 2>/dev/null &
[1] 10415
$ kill -s SIGTERM 10415
$ ps ax | grep flow
10416 s002  S      0:00.85 .../node_modules/flow-bin/flow-osx-v0.57.3/flow server src
10417 s002  S      0:00.01 .../node_modules/flow-bin/flow-osx-v0.57.3/flow
10418 s002  S      0:00.01 .../node_modules/flow-bin/flow-osx-v0.57.3/flow
10419 s002  S      0:00.02 .../node_modules/flow-bin/flow-osx-v0.57.3/flow
10420 s002  S      0:00.01 .../node_modules/flow-bin/flow-osx-v0.57.3/flow
...
mkscrg added a commit to mkscrg/flow-bin that referenced this issue Oct 21, 2017
@mkscrg
kill child process on SIGTERM, fixes flow#88
b525d77
@mkscrg mkscrg mentioned this issue Oct 21, 2017
Open
mkscrg added a commit to mkscrg/flow-bin that referenced this issue Oct 25, 2017
@mkscrg
kill child process on SIGTERM, fixes flow#88
ae7fed4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkscrg