Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Outline and Padding to have their own configurable colors #36

Merged

Conversation

Barbaross93
Copy link

@Barbaross93 Barbaross93 commented Oct 15, 2021

This turned out to be a lot simpler than I expected. Let me know if I need to make any other adjustments, I was able to compile and run it fine. This closes #35.

@florentc florentc changed the base branch from master to feature/enhanced-color-config November 1, 2021 15:46
@florentc
Copy link
Owner

florentc commented Nov 1, 2021

Thank you for the PR. I am merging it in a new feature branch for now because I plan to add a configurable separation line between the filled and unfilled part of the bar (such as in "proportional overflow mode") to be able to style xob like default bars such as in the mpv video player (fully transparent unfilled section with black outlines to make it visible on bright backgrounds). We also need to document these new features. Also there might be discussion as to how to name the fields and handle missing colors in the configuration file to avoid breaking people's config too much while still showcasing the feature.

@florentc florentc merged commit c2cb937 into florentc:feature/enhanced-color-config Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Option to use a specific color for outline and padding
2 participants