Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Damage dealt in fight #142

Open
Bouillot-Rngk opened this issue Apr 25, 2022 · 1 comment
Open

[FEATURE] Damage dealt in fight #142

Bouillot-Rngk opened this issue Apr 25, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request low prio Low priority fix or feature that may get added in the future

Comments

@Bouillot-Rngk
Copy link

Is your feature request related to a problem? Please describe.
Feature is just not there and could be a nice improvement

Describe the solution you'd like
An asset similar to the "gold diff from start" feature but with damage dealt on last fight could improve the "in game analysis" for casters. It's a complex feature, the main problem being "When does a fight start ?", and "Does the memory cache reading give access to this information ?"

Describe alternatives you've considered
To answer the question of "When does a fight start" i have two main ideas :

  • Manual button on app that allows script to start counting damage from one point of time (or retaining the total damage dealt info from this point), second activation (or an other button) will show the damage graph
  • Automatic scripts that start counting damage from one point of time when a threshold is activated for two or three champs, and a button that can show the damage graph
@Bouillot-Rngk Bouillot-Rngk added the enhancement New feature or request label Apr 25, 2022
@Coow
Copy link
Contributor

Coow commented Apr 25, 2022

Would defently be a very nice addition.
Memory reading is outside of my knowledge, so @floh22 would have to get the reading for Damage Dealt inside of the game

@floh22 floh22 added the low prio Low priority fix or feature that may get added in the future label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low prio Low priority fix or feature that may get added in the future
Projects
None yet
Development

No branches or pull requests

3 participants