Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support browser events for unhandled rejection tracking #15

Open
sindresorhus opened this issue Feb 7, 2016 · 2 comments
Open

Support browser events for unhandled rejection tracking #15

sindresorhus opened this issue Feb 7, 2016 · 2 comments

Comments

@sindresorhus
Copy link
Contributor

The naming of the events are slightly different, but should have same behavior.

https://googlechrome.github.io/samples/promise-rejection-events/index.html

I know pinkie is meant for Node.js, but people will still Browserify Node.js stuff that use it.

@ysmood
Copy link

ysmood commented Dec 27, 2016

@sindresorhus Maybe you can give Yaku a try.

@jamestalmage
Copy link
Collaborator

How should we handle the console output?

Chrome currently outputs a nice message that shows the rejected promise:

screenshot 2017-01-01 17 42 14

And then updates when it is later fulfilled:

screenshot 2017-01-01 17 42 53

(Note how the x changes to a check).

I have played with using window.dispatchEvent and it doesn't seem to output anything to the console. It only seems to work with native promises.

I am not sure we should be printing to the console at all, but doing so would better follow the native implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants