Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mismatch between button menu and button panel #4061

Open
Akiva-Cohen opened this issue Jan 5, 2025 · 4 comments
Open

mismatch between button menu and button panel #4061

Akiva-Cohen opened this issue Jan 5, 2025 · 4 comments
Assignees
Labels
Core+Services HAL, furi & core system services Feature Request New feature or user-story you wanna add to flipper

Comments

@Akiva-Cohen
Copy link

Describe the enhancement you're suggesting.

Currently button menu passes the event type to callbacks when a button is pressed, while button panel only calls the callback on a short press. In my opinion button pannel should be changed to be consistent with button menu.

Anything else?

No response

@skotopes skotopes self-assigned this Jan 16, 2025
@skotopes skotopes added Feature Request New feature or user-story you wanna add to flipper Core+Services HAL, furi & core system services labels Jan 16, 2025
@skotopes
Copy link
Member

Yep, sounds reasonable

@Akiva-Cohen
Copy link
Author

Yep, sounds reasonable

I made a pr to solve the issue, but I'm not sure how to link it to the issue

@skotopes
Copy link
Member

Yep I saw it. It will be included in next release

@Akiva-Cohen
Copy link
Author

Yep I saw it. It will be included in next release

this is my first time contributing to something like this. does release mean like some block of prs being added to dev or like is it just going to stay as a pr until main updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core+Services HAL, furi & core system services Feature Request New feature or user-story you wanna add to flipper
Projects
None yet
Development

No branches or pull requests

2 participants