Update Infrared signal selection #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove orders - db normalize fix - detekt fix - TableDao for normalization
- add config device generator
- add dbfile to ignore - add comment to devicekey
- merge model package
- relocate infrared util
- relocate generators
- fix readme - fix dockerfile
- fix database module name
- add button serializer test
- add empty key identifier - fix class comparison of key identifier
- add categories config generator
- add initial logic to signal response
- disable safe checks
- make signal depends on brand - fix sorting brands - add second iteration of signal fetch - add signal linking
- add postgres - add exception for non expisting brands - change signal model
- fix duplicate signals
- fix order signal by file popularity
- fix chunks
- fix selection when empty signals for current order
- fix window size - fix multiple signal add
- add config repository to change it with sql later
- fix DeviceKeyNamesProvidery
- fix device config generator
- add todo
LionZXY
reviewed
Jul 24, 2024
| val includedInfraredFilesCount = transaction(database) { includedFileIds.count() } | ||
| when (includedInfraredFilesCount) { | ||
| 0L -> { | ||
| TODO() |
| val categoryType = CategoryType | ||
| .entries | ||
| .firstOrNull { it.folderName == category.folderName } | ||
| ?: error("Could not find category with folderName ${category.folderName}") |
There was a problem hiding this comment.
Wouldn't it be better to do http error here?
| index: Int | ||
| ): CategoryConfiguration.OrderModel? { | ||
| return AllCategoryConfigGenerator | ||
| .generate(categoryType) |
| } | ||
| val response = SignalResponseModel(ifrFileModel = tableDao.ifrFileById(infraredFileId)) |
There was a problem hiding this comment.
This seems like faulty logic - if we have more than one file left the best solution would be to keep looking between them
| } | ||
| val response = SignalResponseModel(ifrFileModel = tableDao.ifrFileById(infraredFileId)) |
There was a problem hiding this comment.
This seems like faulty logic - if we have more than one file left the best solution would be to keep looking between them
- Use batch inserts to make parser faster
- Fix signal selection
- Fix category configuration read
- fix category config path
- fix random error
- fix device configuration key generation
- fix sha256 generation
- fix signal hash
- fix response of http status code
- fix prints
- update irdb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
This PR introduces new version of infrared signal selection with fixed several issues of previous version
Changes: