Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLQ API for unsideline & GetMessages #170

Open
Tracked by #177
anuj-flipkart opened this issue Oct 24, 2024 · 3 comments · May be fixed by #168
Open
Tracked by #177

DLQ API for unsideline & GetMessages #170

anuj-flipkart opened this issue Oct 24, 2024 · 3 comments · May be fixed by #168
Assignees
@kmrdhruv

Comments

@anuj-flipkart
Copy link
Collaborator

Changes for DLQ APIs.

Unsideline requests
GetMessages
Support for multi permission check in route behavior.
@anuj-flipkart anuj-flipkart linked a pull request Oct 24, 2024 that will close this issue
DLQ API for unsideline & GetMessages #168
Open
@anuj-flipkart anuj-flipkart mentioned this issue Oct 24, 2024
Open
1 task
@kmrdhruv
Copy link
Collaborator

Fixed failing tests.

@kmrdhruv
Copy link
Collaborator

kmrdhruv commented Nov 5, 2024 •
edited
Loading

  • added validations for subscription properties.
  • refactored controllerAPI into ControllerConsumerAPI and ControllerRestAPI to have independent clients for both REST and consumer layers.

Pending

  • Tests
  • Move subscription tunables to config (default values and max allowed)
  • provide super admin override for subscription tunables.

@anuj-flipkart
Copy link
Collaborator Author

getMessageAPI pending, discussion required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmrdhruv kmrdhruv

Labels
None yet
Projects
Varadhi
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DLQ API for unsideline & GetMessages flipkart-incubator/varadhi
2 participants
@kmrdhruv @anuj-flipkart