Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craft 4 Compatibility? #6

Open
smalomo opened this issue Nov 30, 2023 · 6 comments
Open

Craft 4 Compatibility? #6

smalomo opened this issue Nov 30, 2023 · 6 comments

Comments

@smalomo
Copy link

smalomo commented Nov 30, 2023

I see there's a branch for feature/craft-4 that was created last February but it doesn't have any commits and hasn't been updated since. Are there any plans for making the Salesforce and Patron plugins compatible with Craft 4?

@smalomo
Copy link
Author

smalomo commented Jan 4, 2024

@nateiler - bumping this question again as this is blocking a Craft 4 upgrade.

@nateiler
Copy link
Contributor

nateiler commented Jan 4, 2024

Hi @smalomo, sorry for missing this one initially.

Can you try to install using the tagged version 2.0.0

It looks like the docs need to get updated, but v2 should work with Craft 4. I've got an upgrade scheduled this month that will require this version too.

@smalomo
Copy link
Author

smalomo commented Feb 1, 2024

Thanks @nateiler - finally got back around to this and I'm seeing an error when running project-config/apply after getting everything installed/updated.

Patron: Salesforce OAuth2 Provider is installed with schema version of 1.0.0 while 1.1.0 was expected.

Tried chasing this down, but can't figure out which package is expecting 1.1.0 or how to get it resolved.

@nateiler
Copy link
Contributor

nateiler commented Feb 1, 2024

Can you check (and install if not) these other packages. It looks like the Patron OAuth manager might be out of sync.

flipboxfactory/patron:^3.0
flipboxfactory/patron-salesforce:^2.0

@smalomo
Copy link
Author

smalomo commented Feb 1, 2024

Thanks @nateiler for the speedy response~

Here's what I have in composer.json:

"flipboxfactory/craft-salesforce": "2.0",
"flipboxfactory/patron": "^3.0",
"flipboxfactory/patron-salesforce": "^2.0",

As a very unscientific test, I found 

patron-salesforce:
edition: standard
enabled: true
schemaVersion: 1.1.0

in plugins.yaml from when it was first installed 2 years ago. I manually updated that to 1.0.0 and then the project-config/apply ran without any errors. So not sure if that got changed somewhere along the line but I'm going to test this on the staging server. Other than "it works with Craft 4 and doesn't throw errors" is there anything I should look for to confirm that it's running all the correct/latest versions?

@nateiler
Copy link
Contributor

nateiler commented Feb 1, 2024

Great.

I would expect to see the patron-salesforce schema to be 1.3.0 which aligns with the latest version. It's possible this was updated for you, but take a look to see if you're seeing 1.3.0.

The structure of the plugin itself has not changed in quite some time (nothing changed when upgrading for Craft v4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants