-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release library in Flink independent version way #164
Comments
@arnaud-daroussin FYI, there is a proposal to release single library version, but still compiled against the last 3 Flink version in CI. |
Hi @novakov-alexey, The risk I see in removing Flink versions from the bundle versioning is the inability to manage the breaking changes that will come with Flink 2.0. By keeping separate builds and bundles, it will be possible to have different sources root for different Flink versions, like is already the case for Scala 2 and 3. In case of a breaking change with a single bundle, it will be necessary either to:
In conclusion, I am not sure that this is the right time to make this simplification, and I find that the build time of less than 5 minutes is still acceptable. |
Hi @arnaud-daroussin , Thanks for your input! Before Flink 2.0 support, we could live with single version of this library. Then we will probably have two versions: API-1.0-xyz and API-2.0-xyz However, I am not sure how to support Flink 2.0. Will it require to have separate module called |
Context: currently this library is released as 3 separate published JARs for the last 3 Apache Flink versions. For example:
Such approach make the release process quite slow, because it requires 3 bundles to be published to the Sonatype repository.
Also, it forces a user to think which version to select based on his Flink version used in a project. Not a big deal, but why bother with this?
Proposal:
Build and publish a single JAR only without Flink version prepended.
In order to keep Flink compatibility guarantees, still run sbt tests in GH Action for the last 3 Flink version as it is now.
In the result, this library gets verified across different Flink versions, but will have single version schema, which simplifies dependency management process for the users.
Caveats
The text was updated successfully, but these errors were encountered: