Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skybox Cubemaps #162

Open
BenjaFriend opened this issue Oct 1, 2020 · 0 comments
Open

Fix skybox Cubemaps #162

BenjaFriend opened this issue Oct 1, 2020 · 0 comments
Assignees
@BenjaFriend
Labels
bug Something isn't working enhancement New feature or request
Milestone
Perf pass and Cle...

Comments

@BenjaFriend
Copy link
Member

Previously we had skyboxes and cubemaps loading in, but I never got around to adding them in a proper Subpass now that we have the rendering refactor completed.

See Cubemap.h and Cubemap.cpp for examples on how we loaded them in before.

I want to change this so that you don't have to pass in so many arguments to the Cubemap class, but need to do some more reading on the best ways to implement this in Vulkan specifically.
@BenjaFriend BenjaFriend added the enhancement New feature or request label Oct 1, 2020
@BenjaFriend BenjaFriend added this to the Perf pass and Cleanup milestone Oct 1, 2020
@BenjaFriend BenjaFriend self-assigned this Oct 1, 2020
@BenjaFriend BenjaFriend added the bug Something isn't working label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaFriend BenjaFriend

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Perf pass and Cleanup
Development

No branches or pull requests
1 participant
@BenjaFriend