Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to pass connection options for s3 connections #157

Open
lwoodson opened this issue Jan 22, 2013 · 0 comments
Open

Unable to pass connection options for s3 connections #157

lwoodson opened this issue Jan 22, 2013 · 0 comments

Comments

@lwoodson
Copy link

When a Rightscale::HttpConnection is created, params are passed into it which can include options such as :http_connection_open_timeout which defaults to 5. However, the :connection_options are not being passed all the way from the programmer API to the RightAwsBaseInterface constructor. Shouldn't:

https://github.com/rightscale/right_aws/blob/master/lib/awsbase/right_awsbase.rb#L413-L433

Be something like:

https://github.com/lwoodson/right_aws/blob/master/lib/awsbase/right_awsbase.rb#L413-L434

This allows overriding the timeout to work correctly:

opts = {:connection_options => {
    :http_connection_open_timeout => 15,
    :http_connection_retry_count => 5}}
bucket = RightAws::S3.new(S3_ACCESS_KEY, S3_SECRET_KEY, opts).bucket(S3_BUCKET)

I am willing to make the bug fix with tests and submit a pull request if you feel like this is the right fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant