-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic calculation for num_freq on broadband sources #2104
Comments
Nice. My only worry about setting some default is that in principle in FDTD, there is not much of a requirement on the source bandwidth. Even if you're looking at e.g. the C band, it's common to have a source that is much more broadband than that. The problem with setting So the question still is, how do we handle this? |
I guess the main effect in this case would be the incorrect input power normalization, right? Or are there other effects in the injection? |
So, kind of yes, but things can go very wrong, to the point where the simulation even diverges or at least looks like it. That is to say, the injected power could be way off. This is because the temporal signal of the source may not go down to (close to) zero within the simulation run_time, or may even start ramping up. This is because we fit the frequency dependence of the mode with Chebyshev polynomials, and if there's a sharp change in frequency-domain, these can go haywire in the time domain. And in general if the fields do not decay by the end of the run_time, the normalization can be off in a non-trivial way, namely not just a constant prefactor that affects all monitors, but rather every monitor can have a different wrong normalization. |
Is there any chance to validate/check the Chebyshev fit? If it is not valid, fallback to |
Only after the modes are computed. But, we could do that during solver run and write the warning to the log. |
Current
Users set
num_freqs
manually. This parameter is not intuitive, and it takes time to understand and adjust its value.Requirement
We would like to include an optional
auto
setting for this parameter. That would help first-time users to set up broadband sources. PhotonForge already has such a feature.The text was updated successfully, but these errors were encountered: