feat[frontend]: rng in pytest and test cleanup

Author: Gregory Roberts

tests/test_components/test_viz.py

@@ -1,7 +1,6 @@
 """Tests visualization operations."""
 
 import matplotlib.pyplot as plt
-import numpy as np
 import pydantic.v1 as pd
 import pytest
 import tidy3d as td
@@ -147,13 +146,11 @@ def plot_with_viz_spec(alpha, facecolor, edgecolor=None, use_viz_spec=True):
     plt.show()
 
 
-def plot_with_multi_viz_spec(alphas, facecolors, edgecolors, use_viz_spec=True):
+def plot_with_multi_viz_spec(alphas, facecolors, edgecolors, rng, use_viz_spec=True):
     """
     Helper function for plotting simulations with multiple visulation specs via simluation
     plotting function.
     """
-    np.random.seed(3726423)
-
     viz_specs = [
         td.VisualizationSpec(
             facecolor=facecolors[idx], edgecolor=edgecolors[idx], alpha=alphas[idx]
@@ -169,8 +166,8 @@ def plot_with_multi_viz_spec(alphas, facecolors, edgecolors, use_viz_spec=True):
 
     structures = []
     for idx in range(0, len(viz_specs)):
-        center = tuple(list(np.random.uniform(-3, 3, 2)) + [0])
-        size = tuple(np.random.uniform(1, 2, 3))
+        center = tuple(list(rng.uniform(-3, 3, 2)) + [0])
+        size = tuple(rng.uniform(1, 2, 3))
         box = td.Box(center=center, size=size)
 
         structures.append(td.Structure(geometry=box, medium=media[idx]))
@@ -180,12 +177,6 @@ def plot_with_multi_viz_spec(alphas, facecolors, edgecolors, use_viz_spec=True):
         run_time=1e-12,
         structures=structures,
         grid_spec=td.GridSpec(wavelength=1.0),
-        boundary_spec=td.BoundarySpec(
-            x=td.Boundary.pml(num_layers=20),
-        ),
-        shutoff=1e-6,
-        courant=0.8,
-        subpixel=False,
     )
 
     sim.plot(z=0.0)
@@ -217,7 +208,7 @@ def test_plot_from_structure_local():
 
 
 @pytest.mark.skip(reason="Skipping test for CI, but useful for debugging locally with graphics.")
-def test_plot_multi_from_structure_local():
+def test_plot_multi_from_structure_local(rng):
     """
     Local test for visualizing output when creating multiple structures with variety of
     visualization specs.
@@ -226,10 +217,12 @@ def test_plot_multi_from_structure_local():
         alphas=[0.5, 0.75, 0.25, 0.4],
         facecolors=["red", "green", "blue", "orange"],
         edgecolors=["black", "cyan", "magenta", "brown"],
+        rng=rng,
     )
     plot_with_multi_viz_spec(
         alphas=[0.5, 0.75, 0.25, 0.4],
         facecolors=["red", "green", "blue", "orange"],
         edgecolors=["black", "cyan", "magenta", "brown"],
+        rng=rng,
         use_viz_spec=False,
     )