Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fat graphs behave badly when not connected #68

Open
videlec opened this issue Sep 13, 2023 · 3 comments
Open

Fat graphs behave badly when not connected #68

videlec opened this issue Sep 13, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@videlec
Copy link
Contributor

videlec commented Sep 13, 2023

from surface_dynamics import FatGraph
fg = FatGraph('(0,1)(2,3)', '(0,1)(2,3)')
fg.genus()

gives -1 (but it is two genus 0 components)

@videlec videlec mentioned this issue Sep 15, 2023
2 tasks
@fchapoton
Copy link
Contributor

so this should be closed now ?

@saraedum
Copy link
Member

I guess, but the example actually gives product is not identity now @videlec .

@saraedum saraedum added the bug Something isn't working label Nov 12, 2024
@videlec
Copy link
Contributor Author

videlec commented Nov 12, 2024

The input format has changed as well as the output of fg.genus()

sage: fg = FatGraph('(0,1)(2,3)')
sage: fg.genus()
0
sage: fg.is_connected()
False

It is not clear to me whether genus() would better raise an error for disconnected surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants