Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More intelligent default Sdk extension version #494

Open
2 tasks done
hfiguiere opened this issue Oct 15, 2022 · 4 comments
Open
2 tasks done

More intelligent default Sdk extension version #494

hfiguiere opened this issue Oct 15, 2022 · 4 comments

Comments

@hfiguiere
Copy link
Contributor

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

flatpak-builder version

1.2.2

Flatpak version

1.12.7

How to reproduce

  1. Use GNOME or KDE SDK
  2. Add and extension to the manifest (rust-stable will work). Make sure it is NOT installed
  3. Run flatpak-builder

Expected Behavior

It offer to install the matching SDK extension, guessing the proper version, GNOME 43 -> version 22.08

Actual Behavior

It tells me it cant find the SDK extension version 43

Additional Information

The version is in the extension point of the SDK/Runtime.

#469 show we can't specify the SDK extension with a tuple (id//version) that could be an ok workaround

If the right SDK extension is already installed there is no problem.

@hfiguiere hfiguiere added the bug label Oct 15, 2022
@TingPing
Copy link
Member

This just sounds like a new feature. It doesn't really "guess" anything. It just defaults to the same version as the runtime.

@hfiguiere
Copy link
Contributor Author

hfiguiere commented Oct 15, 2022

From a user standpoint it's a bug.

I don't know how feasible that is, but the determination of the version of the extension can be made by checking the extension point for the version property.

@TingPing TingPing added enhancement and removed bug labels Oct 17, 2022
@TingPing TingPing changed the title [Bug]: Sdk extension version guessing incorrect More intelligent default Sdk extension version Oct 17, 2022
@Justinzobel
Copy link

A possible option (from my perspective) would be to have a version specified in the manifest:

    "sdk-extensions": [
        "org.freedesktop.Sdk.Extension.rust-stable//23.08"
    ],

@hfiguiere
Copy link
Contributor Author

A possible option (from my perspective) would be to have a version specified in the manifest:

    "sdk-extensions": [
        "org.freedesktop.Sdk.Extension.rust-stable//23.08"
    ],

See #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants