Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to run CNMF/CNMFE on file that is already motion corrected, not memmapped #1083

Closed
EricThomson opened this issue May 13, 2023 · 3 comments
Labels
status: under development Developers are working on a solution type: feature request

Comments

@EricThomson
Copy link
Contributor

It would be good to explain how to to run source separation on files that are motion corrected but not (yet) memmapped. E.g., someone has a tif from culture/slice with zero motion artifact. This shouldn't be too hard, maybe as simple as adding a sidebar in main notebook to describe how to memmap the file (e.g., if you don't need motion correction, then memmap your file).

I think the route of having it run directly on non-memmapped files is a longer tougher issue as in #750

@loftusa
Copy link

loftusa commented Jun 23, 2023

I second this - I was trying to figure out how to do this and it took me a bit. Would have been nice to just have some code to copy/paste!

@EricThomson
Copy link
Contributor Author

This is already illustrated in CNMFE demo notebook (in the alternate to the if motion_correct branch). I'm currently adding it to CNMF notebook as a "sidebar". Will close when this is pushed to main.

@EricThomson EricThomson added the status: under development Developers are working on a solution label Jul 21, 2023
@EricThomson EricThomson mentioned this issue Oct 24, 2023
21 tasks
@EricThomson
Copy link
Contributor Author

This is merged in PR #1075 will be in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: under development Developers are working on a solution type: feature request
Projects
None yet
Development

No branches or pull requests

2 participants