Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just archive this repo. #102

Closed
raphael-costa opened this issue Dec 8, 2024 · 3 comments · Fixed by #103
Closed

Just archive this repo. #102

raphael-costa opened this issue Dec 8, 2024 · 3 comments · Fixed by #103

Comments

@raphael-costa
Copy link

This flatpak has been broken for literally years now. It serves no purpose other than confusing people.

Many programs don't have a flatpak, just let MEGASync be one of them. One day, if someone fixes the fundamental problems in this manifest, they can create their own repo and push it to flathub.

@loukamb
Copy link

loukamb commented Dec 13, 2024

Agreed. @jasongodev has done some effort on this end and created a flatpak adapted to MEGAsync's new build system, but he wasn't granted authorship over the flatpak on flathub due to concerns of his package's possible future unmaintainability, mainly revolving around the use of regex to patch the package at build time instead of manually providing patches for every file the regex patches. A flatpak maintainer said that those package should be able to be maintained by developers that don't know regex, so a set of patch files for every file each regex his build system targeted must be manually produced and updated for every package version. I did however request MEGA to produce an official flatpak of their build so this can be properly mitigated, since this amount of effort is kinda ridiculous, especially for a single maintainer. It's doubtful they ever will, however.

For now, I'm using jasongodev's version of the flatpak and manually adjusting the flatpak config to install newer versions, since whether developers know or don't know regex is not my or my workplace's concern, only reasonably updated applications and them being available are. I suggest you do that until his solution is eventually rolled in.

@tim77
Copy link
Collaborator

tim77 commented Dec 13, 2024

This flatpak has been broken for literally years now.

This flatpak stopped working properly only in the last ~6 months after the upstream made it impossible to update it. Please don't exaggerate.

It serves no purpose other than confusing people.

At the moment it is. But it used to do his job perfectly and people used him every day for years, including me. Having a proper sandbox in such kind of app is very nice to have.

Some users encountered a bug with the selection of the directory, but this does not mean that the entire application was broken and unusable.

One day, if someone fixes the fundamental problems in this manifest

There are no fundamental problems in this manifest. The fundamental problem is in the application itself. And the upstream's desire to solve problems related to flathub build. Moreover, there were attempts to send the necessary patches into upstream, but the devs ignored them and did not accept them.

One day, if someone fixes the fundamental problems in this manifest, they can create their own repo and push it to flathub.

"Someone" should never push their build to Flathub again. This is against the rules and main requirements of Flathub. A few years ago I pushed it because there was a flathub build request and the upstream didn't mind. But I hoped that in time they would be interested and start supporting this flathub build themselves. But it didn't happen.

tim77 added a commit that referenced this issue Dec 13, 2024
Closes: #102

Signed-off-by: Artem Polishchuk <[email protected]>
tim77 added a commit that referenced this issue Dec 13, 2024
Closes: #102

Signed-off-by: Artem Polishchuk <[email protected]>
@tim77 tim77 mentioned this issue Dec 13, 2024
@tim77 tim77 closed this as completed in 0d4d3b6 Dec 13, 2024
@zefr0x
Copy link

zefr0x commented Dec 31, 2024

There are no fundamental problems in this manifest. The fundamental problem is in the application itself. And the upstream's desire to solve problems related to flathub build. Moreover, there were attempts to send the necessary patches into upstream, but the devs ignored them and did not accept them.

Cloud we have a list of those fundamental problems referred to here?

@flathub flathub locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants