Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm deletion hooks seems not to be obeyed #345

Open
diafour opened this issue Dec 5, 2022 Discussed in #343 · 1 comment
Open

Helm deletion hooks seems not to be obeyed #345

diafour opened this issue Dec 5, 2022 Discussed in #343 · 1 comment
Labels
enhancement New feature or request

Comments

@diafour
Copy link
Contributor

diafour commented Dec 5, 2022

Discussed in #343

Originally posted by oscar-martin November 30, 2022
I have created a module that creates a Job with the next Helm hooks:

  annotations:
    helm.sh/hook: post-install
    helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
    helm.sh/hook-weight: "-5"

Addon-operator is not obeying the Helm deletion hooks. This is what I find in the addon-operator's log:

time="2022-11-30T12:24:38Z" level=debug msg="Absent resources detected" module=mymodule operator.component=HelmResourceMonitor
time="2022-11-30T12:24:38Z" level=debug msg="Detect absent resources for mymodule"
time="2022-11-30T12:24:38Z" level=debug msg=test/Job/test-job
time="2022-11-30T12:24:38Z" level=info msg="got 1 absent module resources, append task ModuleRun for module 'mymodule', phase '', trigger is DetectAbsentHelmResources" operator.component=handleManagerEvents task.flow=add

I have read the topic about release auto-healing and I think that should've been managed.I thought that somehow the addon-operator would check only resources that are not annotated with Helm deletion hooks to make the comparison with the actual state of the Helm release.

Thanks!

@diafour diafour added the enhancement New feature or request label Dec 5, 2022
@sabotup
Copy link

sabotup commented Mar 30, 2023

Is there any update on this? Same issue here.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants