Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-detect siteUrl #154

Open
shivaraj-bh opened this issue Jul 1, 2024 · 1 comment
Open

Auto-detect siteUrl #154

shivaraj-bh opened this issue Jul 1, 2024 · 1 comment

Comments

@shivaraj-bh
Copy link
Collaborator

Manual override of the og:image requires a page.image metadata in the README, like:

---
page:
  image: <my-image.png>
---

# Foo Blog
...

But this doesn’t work if the siteUrl is not configured in index.yaml. See for example:

Before:
og-image-before

After including siteUrl in index.yaml:
og-image-after
shivaraj-bh added a commit to juspay/services-flake that referenced this issue Jul 1, 2024
@shivaraj-bh
chore(doc): Set the right content for og:image HTML meta tag
6533cd2 
`siteUrl` must be configured in `doc/index.yaml` to detect the
`og:image`, see:
flake-parts/community.flake.parts#154
@shivaraj-bh shivaraj-bh added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 1, 2024
@srid
Copy link
Member

srid commented Jul 2, 2024 •
edited
Loading

juspay/services-flake@6533cd2 solves it for services-flake, but not other modules.

A general solution would involve configuring siteUrl automatically ... something to consider as part of srid/emanote#494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srid @shivaraj-bh