Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/refactor /benhmarks under /tests #72

Open
hatkyinc2 opened this issue Apr 12, 2023 · 2 comments
Open

Rename/refactor /benhmarks under /tests #72

hatkyinc2 opened this issue Apr 12, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hatkyinc2
Copy link
Collaborator

hatkyinc2 commented Apr 12, 2023

/tests should be universally understood as it's a standard for stuff that's not in the main code path

Also I think this isn't documented yet in README.md

@hatkyinc2 hatkyinc2 converted this from a draft issue Apr 12, 2023
@hatkyinc2 hatkyinc2 added enhancement New feature or request good first issue Good for newcomers labels Apr 12, 2023
@hatkyinc2 hatkyinc2 moved this from Ideas to Todo in Autopilot Apr 13, 2023
@gantanikhilraj
Copy link

Can you brief the issue @hatkyinc2 , I would like to work on this. also assign it to me

@hatkyinc2
Copy link
Collaborator Author

Hi @gantanikhilraj,

Currently, we are running node benchmarks/yellow_to_red.js to run this single benchmark test.

We should

  • Move the benchmarks directory under tests (doesn't yet exist. End results - running node tests/benchmarks/yellow_to_red.js should work)
  • Add a script inside package.json https://github.com/fjrdomingues/autopilot/blob/main/package.json#L7, which is called benchmarks. That does the above node tests/benchmarks/yellow_to_red.js. End results - running npm run benchmarks should work running that single benchmark for now.
  • Write something in the readme about "Benchmark testing" to run this new script npm run benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

2 participants