-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to configure Rocker to use GuavaHtmlStringify? #169
Comments
If gauva is on the classpath, I believe that becomes the default used. |
TBH by debugging it doesn't seem what's happening... |
Hmm.. it appears the Guava activation was commented out at some point. In RockerStringify: static public final RockerStringify RAW = new RawStringify();
//static public final RockerStringify HTML = RockerRuntime.createDefaultHtmlStringify();
static public final RockerStringify HTML = new DefaultHtmlStringify(); The createDefaultHtmlStringify does activate Guava, otherwise the way it is now, it won't be. Not sure why this is commented out, but if you wanted to uncomment it, and try it locally out and let me know. Not sure if there was a good reason why this was commented out though at some point. |
Actually, I just fixed a unit test that was failing if i re-activated it, and it seems to work well now. I pushed up to master fixing this guava issue. I'll run master thru a number of production tests though to make sure this wasn't significant. |
I cannot find how to configure the template engine to use
GuavaHtmlStringify
instead of the default one for theDefaultRockerTemplate.__internal
if not by manually allocating the view and overrideDefaultRockerTemplate buildTemplate()
to create a custom one (manually crafted) like thisThe text was updated successfully, but these errors were encountered: