Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow Databricks to define database variable #66

Open
1 of 4 tasks
fivetran-joemarkiewicz opened this issue Jun 9, 2023 · 1 comment
Open
1 of 4 tasks
Assignees
Labels
priority:p4 Affects few users; pick up when available status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Currently the package will exclude the shopify_database from being defined if the destination is Databricks. This was appropriate in the past. However, since the addition of the Databricks Unit Catalog there is now a concept of a database structure that some Databricks users may want/need to take advantage of.

This feature is to remove databricks from the exclusion conditional noted below. Please be aware we will still need to include spark as not all spark clusters allow Unity Catalogs. That is a Databricks specific feature.

database: "{% if target.type not in ('spark', 'databricks') %}{{ var('shopify_database', target.database) }}{% endif %}"

Describe alternatives you've considered

There are no real alternatives other than a Databricks user not leveraging the Unity Catalog for database structures.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the enhancement New feature or request label Jun 9, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:enhancement New functionality or enhancement priority:p4 Affects few users; pick up when available status:in_progress Currently being worked on update_type:models Primary focus requires model updates and removed enhancement New feature or request labels Jun 22, 2023
@fivetran-catfritz
Copy link
Contributor

@fivetran-joemarkiewicz Ok to close this? It appears it was addressed in this PR: #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p4 Affects few users; pick up when available status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates
Projects
None yet
Development

No branches or pull requests

2 participants