Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If this happens often in practice, rework flow so that when matchmaking room is full and all connections are alive #472

Open
github-actions bot opened this issue Oct 2, 2024 · 0 comments
Labels
code:todo A TODO/FIXME comment in code.

Comments

@github-actions
Copy link

github-actions bot commented Oct 2, 2024

then have the final connection hand-off be concurrently run without needing to be awaited.


// Send error if room is still full
// TODO: If this happens often in practice, rework flow so that when matchmaking room is full and all connections are alive
// then have the final connection hand-off be concurrently run without needing to be awaited.
if !can_join {
info!(
"[{}] Matchmaking room is full after waiting, rejecting request",
stable_id


This issue was generated by todo-issue based on a TODO comment in 2f4e7ac.
@github-actions github-actions bot added the code:todo A TODO/FIXME comment in code. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code:todo A TODO/FIXME comment in code.
Projects
None yet
Development

No branches or pull requests

0 participants