one bundle is missing sometimes #5

firsttris · 2019-03-05T18:38:48Z

sometimes when we do builds, either the modern or the legacy bundle is missing.

in index.html there is just and empty script tage like this

not quite sure why this happens.

is this because the plugin is using an async tab?

if you have an idea please reply

regards
Tristan

itaditya · 2019-03-15T18:35:59Z

happening with me too.

johnstew · 2019-03-26T01:53:34Z

Hey just following up here. This was the output of my latest attempt.

<!DOCTYPE html>
<html>
  <head>
    <title>Webpack App</title>
    
     
  </head>
  <body>
 
  <script type="module">
            
  </script>

    <script nomodule>
            
                var script0 = document.createElement('script');
                script0.type = 'text/javascript';
                script0.src = 'index_legacy.js';
                document.body.appendChild(script0);
            
    </script>
    
  <script type="text/javascript" src="index_legacy.js"></script></body>
</html>

It looks like this.js is not persisting through the lifecycle of the plugin. It's being created fresh each time beforeHtmlGeneration is being called.

I'm not entirely sure of the correct solution here. I'm not all that familiar with webpack plugins. I'll see if I can take a closer look soon.

Code for reference: johnstew/differential-serving#2

Akiyamka · 2019-06-24T16:23:20Z

It's look crazy, sometime build work fine, but most of time i got just

    <script type="module"></script>
    <script nomodule></script>

=(

firsttris · 2019-06-24T18:39:23Z

@Akiyamka have you noticed any improvement / decline from version 1.1.0 in comperence to 1.0.0 ?

Akiyamka · 2019-06-25T09:04:21Z

@firsttris I started with 1.1.0 version already

Akiyamka · 2019-06-25T09:31:07Z

@firsttris html-webpack-plugin-before-html-generation hook run twice and generate index.html twice - empty and filled version. (I see it in log)
If webpaсk run builds in parallel is a matter of luck which of them will be written in dist last

Akiyamka · 2019-06-25T09:47:15Z

So I found next workaround for that issue -
in first build config i change filename option to 'delete_me.html' and use ignore-emit-webpack-plugin for ignore that file in emit stage.

{
  plugins: [
    new htmlWebpackPlugin({
      inject: !multiBuildMode,
      template,
      filename: '__delete_me__.html',
    }),
    new IgnoreEmitPlugin('__delete_me__.html'),
    new htmlWebpackMultiBuildPlugin()
  ]
}

Now index.html is generated as needed

firsttris · 2019-06-26T10:12:44Z

@Akiyamka well done. good catch.
So the Issue is because it's executed twice and one is empty.
i will add this to the doc's.

carlesnunez · 2019-07-19T10:03:29Z

We are having some problems with the plugin too. Sometimes it put only the output of one of the configs used. Any help that you could provide will be welcome

carlesnunez · 2019-07-19T15:02:54Z

I think that I have an overview idea about what's happening and I have a fix proposal in order to avoid this. It is as you said caused by a twice execution of the html-webpack execution. Which is colliding one vs each other trying to write the file (if is called with the same name). I'll post a fix proposal based into only take into account the last beforeHtmlCreation to call the cb method.

carlesnunez · 2019-07-19T16:32:16Z

First of all I'm not so experienced with webpack plugins but... makes sense to do something like that?

    beforeHtmlGeneration: function(data, cb) {
        this.js = this.js.concat(data.assets.js);
        data.assets.js = this.js;
        data.plugin.options.modernScripts = this.js.filter((value) => value.indexOf('legacy') === -1);
        data.plugin.options.legacyScripts = this.js.filter((value) => value.indexOf('legacy') > 0);
        !this.firstTime ? cb(null, data) : (this.FirstTime = false);
    },

which will be the affectations of not call the cb method on first execution of the plugin? I've tested it and seem to work well but... As I said I'm not an expert about webpack plugins under the hood

carlesnunez · 2019-07-22T09:36:38Z

@firsttris you know which are the affectations of this?

firsttris · 2019-07-25T19:57:53Z

i really don't now. probably my xp with webpack plugins is not better then yours, or even worse

if your fix works it would be a nice solution.

first question which came to my mind:
is "this" still existing event if its executed twice?

if this fixes the build issue i would be happy to add this code...

hbinkle · 2020-03-25T11:57:38Z

any updates on this?
Since I updated to the latest versions of webpack and the html plugins all bundles are missing on every build

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

one bundle is missing sometimes #5

one bundle is missing sometimes #5

firsttris commented Mar 5, 2019

itaditya commented Mar 15, 2019

johnstew commented Mar 26, 2019 •

edited

Loading

Akiyamka commented Jun 24, 2019

firsttris commented Jun 24, 2019

Akiyamka commented Jun 25, 2019

Akiyamka commented Jun 25, 2019 •

edited

Loading

Akiyamka commented Jun 25, 2019 •

edited

Loading

firsttris commented Jun 26, 2019

carlesnunez commented Jul 19, 2019

carlesnunez commented Jul 19, 2019

carlesnunez commented Jul 19, 2019

carlesnunez commented Jul 22, 2019

firsttris commented Jul 25, 2019 •

edited

Loading

hbinkle commented Mar 25, 2020

one bundle is missing sometimes #5

one bundle is missing sometimes #5

Comments

firsttris commented Mar 5, 2019

itaditya commented Mar 15, 2019

johnstew commented Mar 26, 2019 • edited Loading

Akiyamka commented Jun 24, 2019

firsttris commented Jun 24, 2019

Akiyamka commented Jun 25, 2019

Akiyamka commented Jun 25, 2019 • edited Loading

Akiyamka commented Jun 25, 2019 • edited Loading

firsttris commented Jun 26, 2019

carlesnunez commented Jul 19, 2019

carlesnunez commented Jul 19, 2019

carlesnunez commented Jul 19, 2019

carlesnunez commented Jul 22, 2019

firsttris commented Jul 25, 2019 • edited Loading

hbinkle commented Mar 25, 2020

johnstew commented Mar 26, 2019 •

edited

Loading

Akiyamka commented Jun 25, 2019 •

edited

Loading

Akiyamka commented Jun 25, 2019 •

edited

Loading

firsttris commented Jul 25, 2019 •

edited

Loading