Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise header/protocol #69

Open
firepear opened this issue Apr 27, 2024 · 3 comments
Open

Revise header/protocol #69

firepear opened this issue Apr 27, 2024 · 3 comments
Assignees
Milestone

Comments

@firepear
Copy link
Owner

firepear commented Apr 27, 2024

  • There is no reason to send the protocol every time, when we have stateful connections. The connect message should send the protocol version that the client is speaking, and then it should be ignored
  • Request status, at the protocol level, should be indicated in the header. The byte currently used for protocol version can be used for this, resulting in minimal changes to existing code.
@firepear firepear self-assigned this Apr 27, 2024
@firepear firepear changed the title Drop version from header/protocol Revise header/protocol Apr 27, 2024
@firepear
Copy link
Owner Author

Working this and #64 together, as the basis for v0.37.

The base module and client have been overhauled. Starting work on the server, but not sure if I'll get it done tonight. Need to wrap my head around it again first, as it's more complex than the client and has more moving parts.

@firepear
Copy link
Owner Author

firepear commented May 5, 2024

The protocol has been redesigned and the client updated, which leaves the rest as implementation details.

But before this can be closed, a standard hello/protocol version check message needs to be coded in on the client side, and a handler for it implemented on the server side

@firepear firepear added this to the v0.37 milestone Jul 20, 2024
@firepear
Copy link
Owner Author

firepear commented Oct 2, 2024

PROTOCHECK implemented client-side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant