Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork is carrying around a reverted commit #13

Open
connorjward opened this issue Apr 11, 2023 · 0 comments
Open

Fork is carrying around a reverted commit #13

connorjward opened this issue Apr 11, 2023 · 0 comments

Comments

@connorjward
Copy link

For some time this PETSc fork has included an extra commit required for Firedrake to work. This commit removes the following code from fieldsplit.c:

          {
            PetscErrorCode (*func)(KSP,Mat,Mat,void*);
            void            *ctx;

            ierr = DMKSPGetComputeOperators(pc->dm, &func, &ctx);CHKERRQ(ierr);
            ierr = DMKSPSetComputeOperators(dms[i],  func,  ctx);CHKERRQ(ierr);
          }

This is due to an unresolved upstream issue.

See also:

It would be good to fix this upstream. This fork could then simply mirror PETSc main.

connorjward pushed a commit that referenced this issue Aug 23, 2023
Reported-by: Chris Douglas <[email protected]>

[0]PETSC ERROR: --------------------- Error Message --------------------------------------------------------------
[0]PETSC ERROR: Object is in wrong state
[0]PETSC ERROR: Mat object's type is not set: Argument # 1
[0]PETSC ERROR: #1 MatGetFactorAvailable() at src/mat/interface/matrix.c:4820
[0]PETSC ERROR: #2 PCGetDefaultType_Private() at src/ksp/pc/interface/precon.c:25
[0]PETSC ERROR: #3 PCSetUp() at src/ksp/pc/interface/precon.c:1109
[0]PETSC ERROR: #4 KSPSetUp() at src/ksp/ksp/interface/itfunc.c:406
[0]PETSC ERROR: #5 KSPSolve_Private() at src/ksp/ksp/interface/itfunc.c:826
[0]PETSC ERROR: #6 KSPSolveTranspose() at src/ksp/ksp/interface/itfunc.c:1122
[0]PETSC ERROR: #7 PCApplyTranspose_FieldSplit() at src/ksp/pc/impls/fieldsplit/fieldsplit.c:1487
[0]PETSC ERROR: #8 PCApplyTranspose() at src/ksp/pc/interface/precon.c:715
[0]PETSC ERROR: #9 KSP_PCApply() at include/petsc/private/kspimpl.h:380
[0]PETSC ERROR: #10 KSPInitialResidual() at src/ksp/ksp/interface/itres.c:63
[0]PETSC ERROR: #11 KSPSolve_GMRES() at src/ksp/ksp/impls/gmres/gmres.c:226
[0]PETSC ERROR: #12 KSPSolve_Private() at src/ksp/ksp/interface/itfunc.c:900
[0]PETSC ERROR: #13 KSPSolveTranspose() at src/ksp/ksp/interface/itfunc.c:1122
[0]PETSC ERROR: #14 main() at ex9.c:80
[0]PETSC ERROR: Reached the main program with an out-of-range error code 1. This should never happen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant