Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean argument in Nair Lauritzen divergent #28

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

ta440
Copy link
Collaborator

@ta440 ta440 commented Sep 5, 2024

Set the boolean argparse option of --background_flow to default to False. This means that both false and true (--background_flow=True) configurations can be run, whereas previously it became True irrespective of command line input.

Copy link
Collaborator

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim for spotting that this wasn't working.

Two main things:

  • can you apply the same change to the non-divergent test?
  • can you update the calls in the test_transport.py file?

@@ -61,6 +61,8 @@ def nair_lauritzen_divergent(
# Our settings for this set up
# ------------------------------------------------------------------------ #

print(no_background_flow)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I have a habit of doing this!

@tommbendall tommbendall added bug Pull requests or issues to relating to something not working tidying Pull requests or issues that involve tidying up code labels Sep 7, 2024
Copy link
Collaborator

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim!

@tommbendall tommbendall merged commit aeb3510 into main Sep 9, 2024
3 checks passed
@tommbendall tommbendall deleted the fix_NL_boolean_argument branch September 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Pull requests or issues to relating to something not working tidying Pull requests or issues that involve tidying up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants