Allow reference profiles to be updated #542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommbendall
added
enhancement
This was referenced Sep 3, 2024
jshipton
requested changes
Sep 11, 2024
gusto/core/io.py
Outdated
| step = 1 | ||
| last_ref_update_time = None | ||
| initial_steps = None | ||
| time_data = (t, step, initial_steps, last_ref_update_time) |
There was a problem hiding this comment.
I feel slightly concerned about having a tuple of things that I might need to remember the order of! Could we use a named tuple?
Something like (completely untested!):
TimeData = namedtuple('TimeData', ['t', 'step', 'initial_steps', 'last_ref_update_time'])
time_data = TimeData(t, step, initial_steps, last_ref_update_time)
Then you can later access these like: t = time_data.t.
| @@ -302,8 +339,7 @@ def timestep(self): | |||
|
|
|||
| for inner in range(self.num_inner): | |||
|
|
|||
| # TODO: this is where to update the reference state | |||
There was a problem hiding this comment.
Was this comment just wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the reference profiles used in the Semi-Implicit Quasi Newton time stepper to be updated with time.
This is set by an argument to the time stepper. When the reference profiles are updated, the compressible linear solver also needs to recompute some operators. I have also attempted to make this work with checkpointing.