Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydrostatic imbalance diagnostic needs work #336

Open
tommbendall opened this issue Jan 20, 2023 · 1 comment
Open

Hydrostatic imbalance diagnostic needs work #336

tommbendall opened this issue Jan 20, 2023 · 1 comment
Assignees
@Witt-D
Labels
enhancement Pull requests or issues relating to adding a new capability good for hackathon Issues that are good to tackle in a hackathon question Issues that involve a question that needs answering

Comments

@tommbendall
Copy link
Contributor

The hydrostatic imbalance diagnostic does not include the effects of moisture, and it may be sensible for us to ensure that it uses the same solver and problem as is used for computing the pressure gradient / gravity terms. It is only implemented for the compressible equations.
@tommbendall tommbendall added bug Pull requests or issues to relating to something not working enhancement Pull requests or issues relating to adding a new capability question Issues that involve a question that needs answering labels Jan 20, 2023
@tommbendall
Copy link
Contributor Author

The current implementation of this uses the reference profiles to check for imbalance, but it would be better not to do this. We should also:

  • try to use form labelling to select the appropriate terms (which will extend this to work with moisture and other equation sets)
  • considering including the effects of other terms (e.g. metric terms)

@tommbendall tommbendall removed the bug Pull requests or issues to relating to something not working label May 31, 2023
@jshipton jshipton added the good for hackathon Issues that are good to tackle in a hackathon label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Witt-D Witt-D

Labels
enhancement Pull requests or issues relating to adding a new capability good for hackathon Issues that are good to tackle in a hackathon question Issues that involve a question that needs answering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jshipton @tommbendall @Witt-D