Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theta Method maybe shouldn't have theta as an optional argument #329

Closed
tommbendall opened this issue Jan 20, 2023 · 1 comment · Fixed by #397
Closed

Theta Method maybe shouldn't have theta as an optional argument #329

tommbendall opened this issue Jan 20, 2023 · 1 comment · Fixed by #397
Assignees
@atb1995
Labels
good for hackathon Issues that are good to tackle in a hackathon question Issues that involve a question that needs answering

Comments

@tommbendall
Copy link
Contributor

Since theta needs specifying, maybe we shouldn't have this as an optional argument? Or is it important for field_name to be the second argument?
@tommbendall tommbendall added the question Issues that involve a question that needs answering label Jan 20, 2023
@tommbendall tommbendall added the good for hackathon Issues that are good to tackle in a hackathon label May 31, 2023
@atb1995
Copy link
Collaborator

atb1995 commented Jul 25, 2023

I think there is not reason why theta cannot be defined before field_name. Will make a branch to change this

@atb1995 atb1995 linked a pull request Jul 25, 2023 that will close this issue
Move theta input and change error check #397
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atb1995 atb1995

Labels
good for hackathon Issues that are good to tackle in a hackathon question Issues that involve a question that needs answering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move theta input and change error check firedrakeproject/gusto
2 participants
@tommbendall @atb1995