Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limiter should be applied after each stage of RK method #318

Closed
jshipton opened this issue Nov 28, 2022 · 1 comment · Fixed by #413
Closed

Limiter should be applied after each stage of RK method #318

jshipton opened this issue Nov 28, 2022 · 1 comment · Fixed by #413
Assignees
@ta440 @atb1995
Labels
good for hackathon Issues that are good to tackle in a hackathon

Comments

@jshipton
Copy link
Contributor

At the moment the limiter is not applied at each stage of the RK4 method (and Heun's).
@jshipton jshipton assigned jshipton and nhartney and unassigned jshipton Nov 28, 2022
@jshipton jshipton added the good for hackathon Issues that are good to tackle in a hackathon label Jul 24, 2023
@jshipton jshipton assigned ta440 and atb1995 and unassigned nhartney Jul 24, 2023
@jshipton
Copy link
Contributor Author

Assigning @ta440 and @atb1995 as this should happen as part of the rewrite of the RK schemes.

@atb1995 atb1995 linked a pull request Jul 25, 2023 that will close this issue
Move theta input and change error check #397
Merged
@atb1995 atb1995 removed a link to a pull request Jul 25, 2023
Move theta input and change error check #397
Merged
@atb1995 atb1995 linked a pull request Jul 31, 2023 that will close this issue
Butcher Tableau #413
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ta440 ta440

@atb1995 atb1995

Labels
good for hackathon Issues that are good to tackle in a hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Butcher Tableau firedrakeproject/gusto
4 participants
@jshipton @nhartney @ta440 @atb1995