Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename a couple of time steppers / discretisations #283

Closed
tommbendall opened this issue Jul 22, 2022 · 2 comments · Fixed by #397
Closed

Rename a couple of time steppers / discretisations #283

tommbendall opened this issue Jul 22, 2022 · 2 comments · Fixed by #397
Assignees
@atb1995
Labels
enhancement Pull requests or issues relating to adding a new capability good for hackathon Issues that are good to tackle in a hackathon question Issues that involve a question that needs answering

Comments

@tommbendall
Copy link
Contributor

I think we should rename CrankNicolson to SemiImplicitQuasiNewton. I also wonder if we should rename ThetaMethod to TrapezoidalRule or something similar.
@tommbendall tommbendall added enhancement Pull requests or issues relating to adding a new capability question Issues that involve a question that needs answering labels Jul 22, 2022
@jshipton
Copy link
Contributor

I agree to both!

@tommbendall tommbendall added the good for hackathon Issues that are good to tackle in a hackathon label May 31, 2023
@atb1995
Copy link
Collaborator

atb1995 commented Jul 25, 2023

First part has already done. I've had a look through some literature and think ThetaMethod should remain as it is, I can't seem to find a name for u^(n+1) = u^n + dt(alpha*F^(n+1) + (1-alpha)*F^n), other than "General Two-Step Method"..

I think ImplicitMidpoint on the other hand could be called CrankNicholson or TrapeziodalMethod, as it would only be the implicit midpoint rule if the method is linear..

@atb1995 atb1995 linked a pull request Jul 26, 2023 that will close this issue
Move theta input and change error check #397
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atb1995 atb1995

Labels
enhancement Pull requests or issues relating to adding a new capability good for hackathon Issues that are good to tackle in a hackathon question Issues that involve a question that needs answering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move theta input and change error check firedrakeproject/gusto
3 participants
@jshipton @tommbendall @atb1995