Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ufl.split no longer works for TensorProductElement #107

Open
JHopeCollins opened this issue Feb 7, 2023 · 0 comments
Open

ufl.split no longer works for TensorProductElement #107

JHopeCollins opened this issue Feb 7, 2023 · 0 comments
Labels
bug Something isn't working upstream Issue related to upstream dependencies

Comments

@JHopeCollins
Copy link
Collaborator

A recent ufl PR#122 changed the logic in split, so splitting TensorProductElements which are not part of MixedElements now fails (see firedrake/ufl issue #33 and asQ PR #106).
This isn't particularly bad for us for now because for NWP models we always use mixed spaces, but it has broken some of our tests.

We should try to get this fixed in UFL, and reinstate the failing tests in asQ once this happens.
@JHopeCollins JHopeCollins added bug Something isn't working upstream Issue related to upstream dependencies labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream Issue related to upstream dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JHopeCollins