From 6fe5d922106bd0ac4856bc48c820fcdd4dba5488 Mon Sep 17 00:00:00 2001 From: Georgiy Lebedev Date: Tue, 8 Aug 2023 14:05:05 +0300 Subject: [PATCH] Remove `addVsocksHandler` from `loadSnapshotHandlerList` According to the firecracker OpenAPI specification [1], creating vsock devices is only a pre-boot request, so adding vsocks after loading a snapshot fails. It also seems redundant, since the VM loaded from a snapshot restores vsocks anyways. Closes #506 1. https://github.com/firecracker-microvm/firecracker/blob/56aeeac51c00b449a45be4542b3e807d34690ba7/src/api_server/swagger/firecracker.yaml#L676-L678 Signed-off-by: Georgiy Lebedev --- handlers.go | 1 - 1 file changed, 1 deletion(-) diff --git a/handlers.go b/handlers.go index d9d022d8..a20c22f1 100644 --- a/handlers.go +++ b/handlers.go @@ -321,7 +321,6 @@ var loadSnapshotHandlerList = HandlerList{}.Append( CreateLogFilesHandler, BootstrapLoggingHandler, LoadSnapshotHandler, - AddVsocksHandler, ) var defaultValidationHandlerList = HandlerList{}.Append(