-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: Firecamp send an "HTTPS" request even if the URL starts with "HTTP:// #243
Comments
Hello, @om3rcitak I would like to work on this bug. Please assign me this issue. I will fix this as soon as possible. |
Hey can you assigne this issue ? |
Yep, noticed this bug too and came here to check the issues |
So had a quick look into this. For me, when using firecamp in the browser, the Content Security Policy Lines 40 to 43 in abfc292
I think the original commit author was under an incorrect assumption that adding this directive would allow http requests, judging from this commit message. From MDN
Removing this line from the template file allowed me to make requests locally via http successfully. This is something I would expect an API workbench like firecamp to be able to do. Might pull together a PR but it would require some input about toggling the CSP features on/off as there may be other security tradeoffs involved. |
Raised in firecamp-dev#243 Previously, it was not possible to make a http request from the web client as the request would be transparently upgraded to https. This was consequence of an applied content security policy header with a directive to upgrade insecure requests. This change removes this CSP tag, meaning http requests are no longer forcibly upgraded.
Describe the bug
Firecamp is trying to send an "HTTPS" request even if the URL starts with "HTTP://".
To Reproduce
Expected behavior
Send a HTTP request if the URL starts with "http://"
Screenshots
Desktop:
The text was updated successfully, but these errors were encountered: