You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
There's no clear way to identify the Gas Station as source or destination via the SDK due to it missing from PeerType.
Describe the solution you'd like
With the new Gas station 2.0 which becomes the standard 1st of July, according to your guide (https://support.fireblocks.io/hc/en-us/articles/11602800877596-Setup-for-Gas-Station-2-0), it should be easy to identify it in your SDK using the "createdBy" field. This would allow cleaner code from SDK users as we currently have to do these checks ourselves.
If backwards compatibility is required, it's still possible to implement the check, altough it's not as fail-safe: before 2.0 we were checking if NotificationBody.data.source.name or NotificationBody.data.destination.name contained the string "Gas station".
PS: Seems you don't have a mapping layer, which would be needed for this unless you implement it on API level instead of SDK level.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
There's no clear way to identify the Gas Station as source or destination via the SDK due to it missing from PeerType.
Describe the solution you'd like
With the new Gas station 2.0 which becomes the standard 1st of July, according to your guide (https://support.fireblocks.io/hc/en-us/articles/11602800877596-Setup-for-Gas-Station-2-0), it should be easy to identify it in your SDK using the "createdBy" field. This would allow cleaner code from SDK users as we currently have to do these checks ourselves.
If backwards compatibility is required, it's still possible to implement the check, altough it's not as fail-safe: before 2.0 we were checking if
NotificationBody.data.source.name
orNotificationBody.data.destination.name
contained the string "Gas station".PS: Seems you don't have a mapping layer, which would be needed for this unless you implement it on API level instead of SDK level.
The text was updated successfully, but these errors were encountered: