Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add Gas station to PeerType #282

Open
andrecadete opened this issue Jun 25, 2024 · 0 comments
Open

[Feature Request] Add Gas station to PeerType #282

andrecadete opened this issue Jun 25, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@andrecadete
Copy link

andrecadete commented Jun 25, 2024

Is your feature request related to a problem? Please describe.
There's no clear way to identify the Gas Station as source or destination via the SDK due to it missing from PeerType.

Describe the solution you'd like
With the new Gas station 2.0 which becomes the standard 1st of July, according to your guide (https://support.fireblocks.io/hc/en-us/articles/11602800877596-Setup-for-Gas-Station-2-0), it should be easy to identify it in your SDK using the "createdBy" field. This would allow cleaner code from SDK users as we currently have to do these checks ourselves.

If backwards compatibility is required, it's still possible to implement the check, altough it's not as fail-safe: before 2.0 we were checking if NotificationBody.data.source.name or NotificationBody.data.destination.name contained the string "Gas station".

PS: Seems you don't have a mapping layer, which would be needed for this unless you implement it on API level instead of SDK level.

@andrecadete andrecadete added the enhancement New feature or request label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants