Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SendExpenseClassification #19

Open
umitcel opened this issue Jul 1, 2024 · 5 comments
Open

SendExpenseClassification #19

umitcel opened this issue Jul 1, 2024 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@umitcel
Copy link

umitcel commented Jul 1, 2024

Hello,
It seems SendExpenseClassification method is not implemented. Do you plan to implement? Until now have you tried to send any expense classfication against a vendor invoice? Actually I tried to send but service gives aunexpected errors

@firebed
Copy link
Owner

firebed commented Jul 1, 2024

Hi,
Thanks for the notice. Can you please provide the code you tried alongside the response you got? I will definately have a look at it.

@umitcel
Copy link
Author

umitcel commented Jul 1, 2024

The code:

curl --location 'https://mydatapi.aade.gr/myDATA/SendExpensesClassification' \ --header 'aade-user-id: VassilisAivatoglou' \ --header 'Ocp-Apim-Subscription-Key: ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ' \ --header 'Content-Type: application/xml' \ --data '<?xml version="1.0" encoding="utf-8"?> <ExpensesClassificationsDoc xmlns="https://www.aade.gr/myDATA/expensesClassificaton/v1.0"> <expensesInvoiceClassification> <invoiceMark>YYYYYYYYYYY</invoiceMark> <entityVatNumber>XXXXXXXXXX</entityVatNumber> <invoicesExpensesClassificationDetails> <lineNumber>1</lineNumber> <expensesClassificationDetailData> <classificationType>E3_585_016</classificationType> <classificationCategory>category2_3</classificationCategory> <amount>6854.99</amount> <vatCategory>1</vatCategory> </expensesClassificationDetailData> </invoicesExpensesClassificationDetails> </expensesInvoiceClassification> </ExpensesClassificationsDoc>'

Response:
<?xml version="1.0" encoding="utf-8"?> <ResponseDoc xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> <response> <index>1</index> <statusCode>ValidationError</statusCode> <errors> <error> <message>Combination vatCategory 1, vatExemptionCategory null: Fields vatAmount, vatCategory and vatExemptionCategory must be null when classifications are posted per line </message> <code>337</code> </error> <error> <message>VAT classifications is mandatory for invoice detail 1</message> <code>230</code> </error> </errors> </response> </ResponseDoc>

I ananomized some fields.

@firebed
Copy link
Owner

firebed commented Jul 1, 2024

Just to clarify what's going on here. I don't see any code related to this package. You are sending the request directly by youself using curl and I can't tell if the XML was generated by this package or not. The response error indicates the data is missing some required fields.

@umitcel
Copy link
Author

umitcel commented Jul 1, 2024

Yes your code doesn't have this method implemented yet. I shared my own experience.

@firebed
Copy link
Owner

firebed commented Jul 1, 2024

Yes you're right. It is not implemented yet. I plan to release this in the upcoming version 5.x-1.0.9-dev. The release is estimated to happend in 1-2 months from now as it primarily depends on mydata. As soon as myDATA makes 1.0.9 ready for production I will release a major v5 version too.

@firebed firebed added enhancement New feature or request help wanted Extra attention is needed labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants