Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would a patchlevel release be possible or is planned already ? #578

Closed
sbuerk opened this issue Sep 29, 2024 · 13 comments
Closed

Would a patchlevel release be possible or is planned already ? #578

sbuerk opened this issue Sep 29, 2024 · 13 comments

Comments

@sbuerk
Copy link

sbuerk commented Sep 29, 2024

Is there any plan for a next (patchlevel) release ? Could not ind any release schedule.

Specially regarding the PHP8.4 required changes of merged #572 ?

@sbuerk sbuerk changed the title Patchlevel release Would a patchlevel release be possible or is planned already ? Sep 29, 2024
@lolli42
Copy link

lolli42 commented Oct 11, 2024

ping.

@lolli42
Copy link

lolli42 commented Oct 24, 2024

Ping.
PHP is at 8.4.0 rc2, would be great to have a compat release of this library.

@ruudk
Copy link

ruudk commented Oct 31, 2024

@bshaffer You are probably very busy, but could you please tag a new release so that projects that rely on this have a few less errors to worry about when preparing for PHP 8.4 😅 🙏

@ruudk
Copy link

ruudk commented Nov 13, 2024

@ajupazhamayil would you be able to help out with this?

@standa
Copy link

standa commented Nov 20, 2024

If this helps to anyone: we are running on the commit pin (which seems to work for the time being).

	"require": {
		"firebase/php-jwt": "dev-main#76808fa",
}

Just note composer validate complains a bit 😞

# General warnings
- The package "firebase/php-jwt" is pointing to a commit-ref, this is bad practice and can cause unforeseen issues.

@sbuerk
Copy link
Author

sbuerk commented Nov 23, 2024

Since PHP 8.4.1 has been released some days ago, could we expect a patchlevel release of this library containing already merged fixes after these couple of months?

It does not show much trust if a framework needs to say:

You can use our framework safely with PHP8.4, but as we rely on XY you need to use a composer patch for already merged but not released PHP8.4 fixes.

to announce official PHP8.4 support.

@hafezdivandari
Copy link

It seems that the repo is using the release-please bot for releases, and this bot doesn't take chore commits into account!

@sbuerk
Copy link
Author

sbuerk commented Nov 23, 2024

It seems that the repo is using the release-please bot for releases, and this bot doesn't take chore commits into account!

Damn. Should have made one of the pr commits a fix. What a pity that is not mentioned within the README.md.

@ruudk
Copy link

ruudk commented Nov 24, 2024

So would it help if we do a new PR with a proper commit to get it tagged? There's probably something tiny code style thing we can tweak / fix.

ruudk added a commit to ruudk/php-jwt that referenced this issue Nov 24, 2024
Adds PHP 8.4 to the CI matrix.

See firebase#572 and firebase#578
@ruudk
Copy link

ruudk commented Nov 24, 2024

@hafezdivandari @sbuerk I think it would be solved with #583, agreed?

@sbuerk
Copy link
Author

sbuerk commented Nov 24, 2024

@hafezdivandari @sbuerk I think it would be solved with #583, agreed?

not sure if deps would lead to a release (don't know release-please) ... not that we have the same issue with the pr because it was only chore.

@hafezdivandari
Copy link

hafezdivandari commented Nov 24, 2024

They usually squash and merge, so the fix prefix on the #583 PR title makes it a releasable unit 👍

@ruudk
Copy link

ruudk commented Nov 24, 2024

This can be closed

#585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@bshaffer @ruudk @standa @sbuerk @lolli42 @hafezdivandari and others