Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong current payload in setRestaurantDetails #292

Open
johnnyoshika opened this issue May 17, 2024 · 0 comments · May be fixed by #307
Open

Wrong current payload in setRestaurantDetails #292

johnnyoshika opened this issue May 17, 2024 · 0 comments · May be fixed by #307

Comments

@johnnyoshika
Copy link

There is a bug here: https://github.com/firebase/friendlyeats-web/blob/master/nextjs-start/src/components/Restaurant.jsx#L44

Instead of:

setRestaurantDetails({ ...restaurant, photo: imageURL });

It should be:

setRestaurantDetails({ ...restaurantDetails, photo: imageURL });
@jamesdaniels jamesdaniels linked a pull request Sep 11, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing the service worker config firebase/friendlyeats-web
1 participant
@johnnyoshika