From 041b39a2ba1b0c6c1dafe39b4bc03c53a532202a Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Thu, 1 Feb 2024 16:09:43 -0800 Subject: [PATCH 1/2] Downversion to upload-artifact@v3 --- .../workflows/health-metrics-presubmit.yml | 26 ++++++++++--------- scripts/health_metrics/README.md | 3 +-- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/.github/workflows/health-metrics-presubmit.yml b/.github/workflows/health-metrics-presubmit.yml index 0a91c454492..61ef5a17a26 100644 --- a/.github/workflows/health-metrics-presubmit.yml +++ b/.github/workflows/health-metrics-presubmit.yml @@ -72,7 +72,7 @@ jobs: run: scripts/setup_bundler.sh - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseABTesting --platform=${{ matrix.target }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 with: name: codecoverage path: /Users/runner/*.xcresult @@ -92,7 +92,7 @@ jobs: run: scripts/setup_bundler.sh - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseAuth --platform=${{ matrix.target }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 with: name: codecoverage path: /Users/runner/*.xcresult @@ -115,7 +115,9 @@ jobs: run: scripts/setup_bundler.sh - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseDatabase --platform=${{ matrix.target }} - - uses: actions/upload-artifact@v4 + # TODO: Make sure that https://github.com/actions/upload-artifact/issues/478 is resolved + # before going to actions/upload-artifact@v4. + - uses: actions/upload-artifact@v3 with: name: codecoverage path: /Users/runner/*.xcresult @@ -138,7 +140,7 @@ jobs: run: scripts/setup_bundler.sh - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseDynamicLinks --platform=${{ matrix.target }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 with: name: codecoverage path: /Users/runner/*.xcresult @@ -164,7 +166,7 @@ jobs: run: | export EXPERIMENTAL_MODE=true ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseFirestore --platform=${{ matrix.target }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 with: name: codecoverage path: /Users/runner/*.xcresult @@ -187,7 +189,7 @@ jobs: run: scripts/setup_bundler.sh - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseFunctions --platform=${{ matrix.target }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 with: name: codecoverage path: /Users/runner/*.xcresult @@ -210,7 +212,7 @@ jobs: run: scripts/setup_bundler.sh - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseInAppMessaging --platform=${{ matrix.target }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 with: name: codecoverage path: /Users/runner/*.xcresult @@ -233,7 +235,7 @@ jobs: run: scripts/setup_bundler.sh - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseMessaging --platform=${{ matrix.target }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 with: name: codecoverage path: /Users/runner/*.xcresult @@ -258,7 +260,7 @@ jobs: run: gem install xcpretty - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebasePerformance --platform=${{ matrix.target }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 with: name: codecoverage path: /Users/runner/*.xcresult @@ -281,7 +283,7 @@ jobs: run: scripts/setup_bundler.sh - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseRemoteConfig --platform=${{ matrix.target }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 with: name: codecoverage path: /Users/runner/*.xcresult @@ -304,7 +306,7 @@ jobs: run: scripts/setup_bundler.sh - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseStorage --platform=${{ matrix.target }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 with: name: codecoverage path: /Users/runner/*.xcresult @@ -331,7 +333,7 @@ jobs: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/metrics_service_access.json.gpg \ metrics-access.json "${{ env.METRICS_SERVICE_SECRET }}" gcloud auth activate-service-account --key-file metrics-access.json - - uses: actions/download-artifact@v4 + - uses: actions/download-artifact@v3 id: download with: path: /Users/runner/test diff --git a/scripts/health_metrics/README.md b/scripts/health_metrics/README.md index d3f22f25412..def21a6bef1 100644 --- a/scripts/health_metrics/README.md +++ b/scripts/health_metrics/README.md @@ -33,8 +33,7 @@ pod-lib-lint-newsdk: run: scripts/setup_bundler.sh - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh FirebaseNewSDK "${{ matrix.target }}" - - uses: actions/upload-artifact@v2 - with: + - uses: actions/upload-artifact@v3 name: codecoverage path: /Users/runner/*.xcresult ``` From 8ceec5a4a6a60ff6640bb44fd0fc904ff11c17a8 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Thu, 1 Feb 2024 16:12:34 -0800 Subject: [PATCH 2/2] erroneous delete --- scripts/health_metrics/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/health_metrics/README.md b/scripts/health_metrics/README.md index def21a6bef1..829cfeae24c 100644 --- a/scripts/health_metrics/README.md +++ b/scripts/health_metrics/README.md @@ -34,6 +34,7 @@ pod-lib-lint-newsdk: - name: Build and test run: ./scripts/health_metrics/pod_test_code_coverage_report.sh FirebaseNewSDK "${{ matrix.target }}" - uses: actions/upload-artifact@v3 + with: name: codecoverage path: /Users/runner/*.xcresult ```