diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ccb719df2f2..eb913e8f805 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -132,7 +132,7 @@ To develop Firebase software, **install**: To install [clang-format] and [mint] using [Homebrew]: ```console - brew install clang-format@16 + brew install clang-format@17 brew install mint ``` diff --git a/FirebaseAuth/Sources/Auth/FIRAuth.m b/FirebaseAuth/Sources/Auth/FIRAuth.m index c0697eba371..092d357b04e 100644 --- a/FirebaseAuth/Sources/Auth/FIRAuth.m +++ b/FirebaseAuth/Sources/Auth/FIRAuth.m @@ -2373,7 +2373,7 @@ - (BOOL)saveUser:(nullable FIRUser *)user error:(NSError *_Nullable *_Nullable)o #else // Encode the user object. NSMutableData *archiveData = [NSMutableData data]; -// iOS 12 deprecation + // iOS 12 deprecation #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wdeprecated-declarations" NSKeyedArchiver *archiver = @@ -2439,7 +2439,7 @@ - (BOOL)getUser:(FIRUser *_Nullable *)outUser error:(NSError *_Nullable *_Nullab return NO; } #else -// iOS 12 deprecation + // iOS 12 deprecation #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wdeprecated-declarations" NSKeyedUnarchiver *unarchiver = @@ -2621,7 +2621,7 @@ - (nullable FIRUser *)getStoredUserForAccessGroup:(NSString *_Nullable)accessGro return nil; } #else -// iOS 12 deprecation + // iOS 12 deprecation #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wdeprecated-declarations" NSKeyedUnarchiver *unarchiver = diff --git a/FirebaseAuth/Sources/SystemService/FIRAuthAppCredentialManager.m b/FirebaseAuth/Sources/SystemService/FIRAuthAppCredentialManager.m index 52673f01fca..005a63c2aa1 100644 --- a/FirebaseAuth/Sources/SystemService/FIRAuthAppCredentialManager.m +++ b/FirebaseAuth/Sources/SystemService/FIRAuthAppCredentialManager.m @@ -73,7 +73,7 @@ - (instancetype)initWithKeychain:(FIRAuthKeychainServices *)keychain { NSKeyedUnarchiver *unarchiver = [[NSKeyedUnarchiver alloc] initForReadingFromData:encodedData error:&error]; #else -// iOS 12 deprecation + // iOS 12 deprecation #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wdeprecated-declarations" NSKeyedUnarchiver *unarchiver = diff --git a/FirebaseAuth/Sources/SystemService/FIRAuthStoredUserManager.m b/FirebaseAuth/Sources/SystemService/FIRAuthStoredUserManager.m index 8a8fd30574a..86ed8dee85f 100644 --- a/FirebaseAuth/Sources/SystemService/FIRAuthStoredUserManager.m +++ b/FirebaseAuth/Sources/SystemService/FIRAuthStoredUserManager.m @@ -89,7 +89,7 @@ - (FIRUser *)getStoredUserForAccessGroup:(NSString *)accessGroup return nil; } #else -// iOS 12 deprecation + // iOS 12 deprecation #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wdeprecated-declarations" NSKeyedUnarchiver *unarchiver = [[NSKeyedUnarchiver alloc] initForReadingWithData:data]; @@ -118,7 +118,7 @@ - (BOOL)setStoredUser:(FIRUser *)user NSKeyedArchiver *archiver = [[NSKeyedArchiver alloc] initRequiringSecureCoding:false]; #else NSMutableData *data = [NSMutableData data]; -// iOS 12 deprecation + // iOS 12 deprecation #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wdeprecated-declarations" NSKeyedArchiver *archiver = [[NSKeyedArchiver alloc] initForWritingWithMutableData:data]; diff --git a/README.md b/README.md index a22788c5953..b35d89bf045 100644 --- a/README.md +++ b/README.md @@ -153,7 +153,7 @@ GitHub Actions will verify that any code changes are done in a style-compliant way. Install `clang-format` and `mint`: ```console -brew install clang-format@16 +brew install clang-format@17 brew install mint ``` diff --git a/scripts/setup_check.sh b/scripts/setup_check.sh index 88c138a1063..9e62317b8df 100755 --- a/scripts/setup_check.sh +++ b/scripts/setup_check.sh @@ -35,7 +35,7 @@ fi # install clang-format brew update -brew install clang-format@16 +brew install clang-format@17 # mint installs tools from Mintfile on demand. brew install mint diff --git a/scripts/style.sh b/scripts/style.sh index a350f7c79ec..c08dd1ed1f9 100755 --- a/scripts/style.sh +++ b/scripts/style.sh @@ -56,7 +56,7 @@ version="${version/ (*)/}" version="${version/.*/}" case "$version" in - 16) + 17) ;; google3-trunk) echo "Please use a publicly released clang-format; a recent LLVM release" @@ -65,7 +65,7 @@ case "$version" in exit 1 ;; *) - echo "Please upgrade to clang-format version 16." + echo "Please upgrade to clang-format version 17." echo "If it's installed via homebrew you can run:" echo "brew upgrade clang-format" exit 1