Skip to content

Commit

Permalink
[NFC] Fix typos: XCode -> Xcode (#12294)
Browse files Browse the repository at this point in the history
  • Loading branch information
ncooke3 authored Jan 17, 2024
1 parent fc08f4d commit 641e6f8
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion FirebasePerformance/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ The above command should be sufficient for most scenarios. Few more options list

- `sh generate_project.sh` (or) `sh generate_project.sh -e "autopush"`

### Re-generate XCode project by deleting old XCode project
### Re-generate Xcode project by deleting old Xcode project

- `sh generate_project.sh -c`
4 changes: 2 additions & 2 deletions FirebasePerformance/generate_project.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ helpFunction()
echo ""
echo "Usage: $0 -e (prod/autopush*) -p (platform)"
echo -e "\tEvent upload environment - prod (or) autopush. Default: autopush"
echo -c "\tRecreate the Xcode project from scratch. Default: Reuse same XCode project"
echo -c "\tRecreate the Xcode project from scratch. Default: Reuse same Xcode project"
exit 1 # Exit script after printing help
}

Expand Down Expand Up @@ -67,7 +67,7 @@ if [ -z "$clean" ]
then
pod gen "$DIR/FirebasePerformance.podspec" --local-sources="$DIR/" --auto-open --gen-directory="$DIR/gen" --platforms="$platform"
else
echo "\nCreating a fresh Fireperf XCode project."
echo "\nCreating a fresh Fireperf Xcode project."
rm -f "$DIR/FirebasePerformance/ProtoSupport/*.[hm]"
protoc --proto_path="$DIR/FirebasePerformance/ProtoSupport/" --objc_out="$DIR/FirebasePerformance/ProtoSupport/" "$DIR/FirebasePerformance/ProtoSupport/perf_metric.proto"
pod gen "$DIR/FirebasePerformance.podspec" --local-sources="$DIR/" --auto-open --gen-directory="$DIR/gen" --platforms="$platform" --clean
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# folder defined by SCRIPT_INPUT_FILE_0 and the generated binary protos are
# stored in the folder defined by SCRIPT_OUTPUT_FILE_0. Both SCRIPT_INPUT_FILE_0
# and SCRIPT_OUTPUT_FILE_0 are defined in the Run Script Build Phase of the
# XCode build target Firestore_FuzzTests_iOS that executes this script. XCode
# Xcode build target Firestore_FuzzTests_iOS that executes this script. Xcode
# defines these environment variables and makes them available to the script.
#
# By default Xcode build phase scripts run in a stripped down environment that
Expand Down
2 changes: 1 addition & 1 deletion Firestore/core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ endif()

## gRPC Certificates

# Source files should be generated in place so that the XCode build can pick
# Source files should be generated in place so that the Xcode build can pick
# them up.
set(OUTPUT_DIR ${CMAKE_CURRENT_SOURCE_DIR}/src/remote)

Expand Down
2 changes: 1 addition & 1 deletion Firestore/core/src/nanopb/pretty_printing.cc
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ std::string ToString(float value) {
// TODO(varconst): raise the precision.
// The Objective-C protobuf library would use higher precision. E.g., it would
// output 1.79769313486232e+308 in case where this implementation would only
// output 1.79769e+308 (tested in XCode 11, iOS simulator).
// output 1.79769e+308 (tested in Xcode 11, iOS simulator).
std::ostringstream stream;
stream << value;
return stream.str();
Expand Down
6 changes: 3 additions & 3 deletions Firestore/core/test/unit/FSTGoogleTestTests.mm
Original file line number Diff line number Diff line change
Expand Up @@ -231,19 +231,19 @@ void XCTestMethod(XCTestCase* self, SEL _cmd) {

const testing::TestResult* result = testInfo->result();
if (result->Passed()) {
// Let XCode know that the test ran and succeeded.
// Let Xcode know that the test ran and succeeded.
XCTAssertTrue(true);
return;
} else if (result->Skipped()) {
#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 130400 || \
__TV_OS_VERSION_MAX_ALLOWED >= 130400 || \
__MAC_OS_X_VERSION_MAX_ALLOWED >= 101504
// Let XCode know that the test was skipped.
// Let Xcode know that the test was skipped.
XCTSkip();
#endif
}

// Test failed :-(. Record the failure such that XCode will navigate directly
// Test failed :-(. Record the failure such that Xcode will navigate directly
// to the file:line.
int parts = result->total_part_count();
for (int i = 0; i < parts; i++) {
Expand Down

0 comments on commit 641e6f8

Please sign in to comment.