From 5a48703d0905bdc9234e497b42cabca6d5e7a0d4 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Mon, 23 Sep 2024 20:26:11 -0700 Subject: [PATCH] fixes --- .github/workflows/abtesting.yml | 2 +- .github/workflows/appdistribution.yml | 2 +- .github/workflows/auth.yml | 2 +- FirebaseAuth.podspec | 4 +++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/abtesting.yml b/.github/workflows/abtesting.yml index 6b914e963f5..aecc4da9c2c 100644 --- a/.github/workflows/abtesting.yml +++ b/.github/workflows/abtesting.yml @@ -78,7 +78,7 @@ jobs: - uses: actions/cache/restore@v4 with: path: .build - key: ${{ steps.spm-package-resolved.outputs.cache_key }} + key: ${{needs.spm-package-resolved.outputs.cache_key}} - name: Xcode run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer - name: Initialize xcodebuild diff --git a/.github/workflows/appdistribution.yml b/.github/workflows/appdistribution.yml index 8ecf6afebec..d44c7ad19a5 100644 --- a/.github/workflows/appdistribution.yml +++ b/.github/workflows/appdistribution.yml @@ -72,7 +72,7 @@ jobs: - uses: actions/cache/restore@v4 with: path: .build - key: ${{ steps.spm-package-resolved.outputs.cache_key }} + key: ${{needs.spm-package-resolved.outputs.cache_key}} - name: Xcode run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer - name: Initialize xcodebuild diff --git a/.github/workflows/auth.yml b/.github/workflows/auth.yml index 0750644143b..4b7c9af6dfc 100644 --- a/.github/workflows/auth.yml +++ b/.github/workflows/auth.yml @@ -158,7 +158,7 @@ jobs: - uses: actions/cache/restore@v4 with: path: .build - key: ${{ steps.spm-package-resolved.outputs.cache_key }} + key: ${{needs.spm-package-resolved.outputs.cache_key}} - name: Xcode run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer - name: Initialize xcodebuild diff --git a/FirebaseAuth.podspec b/FirebaseAuth.podspec index 5bb6a6b1eec..7c35e277736 100644 --- a/FirebaseAuth.podspec +++ b/FirebaseAuth.podspec @@ -48,11 +48,13 @@ supports email and password accounts, as well as several 3rd party authenticatio 'FirebaseAuth/README.md', 'FirebaseAuth/CHANGELOG.md' ] + # TODO(#13704) Restore warnings-as-errors checking. + # 'OTHER_SWIFT_FLAGS' => "$(inherited) #{ENV.key?('FIREBASE_CI') ? '-D FIREBASE_CI -warnings-as-errors' : ''}" s.pod_target_xcconfig = { 'GCC_C_LANGUAGE_STANDARD' => 'c99', # The second path is to find FirebaseAuth-Swift.h from a pod gen project 'HEADER_SEARCH_PATHS' => '"${PODS_TARGET_SRCROOT}" "${OBJECT_FILE_DIR_normal}/${NATIVE_ARCH_ACTUAL}"', - 'OTHER_SWIFT_FLAGS' => "$(inherited) #{ENV.key?('FIREBASE_CI') ? '-D FIREBASE_CI -warnings-as-errors' : ''}" + 'OTHER_SWIFT_FLAGS' => "$(inherited) #{ENV.key?('FIREBASE_CI') ? '-D FIREBASE_CI' : ''}" } s.framework = 'Security' s.ios.framework = 'SafariServices'